[Stackless] Patch for pickle problem on 64bit platforms

[Kristján Valur Jónsson]

Interesting.
This is because the variables i and n on the cframe are of type "long".
Now, this type is 64 bit long on 64 bit linux, but it remains 32 bits on 64 bit Windows.
What is this used for?  Is there a reason this is "long" and not "int"?
Should we perhaps use Py_SSIZE_T instead which is consistently 64 bits on 64 bit windows and unix?

One should avoid types such as "long" on code that is supposed to work identically on windows and unix.

K

-----Original Message-----
From: stackless-bounces at stackless.com [mailto:stackless-bounces at stackless.com] On Behalf Of Hallgrimur H. Gunnarsson
Sent: Wednesday, October 17, 2007 01:23
To: stackless at stackless.com
Subject: [Stackless] Patch for pickle problem on 64bit platforms

Hi all,

The following patch fixes the pickle problem on 64bit platforms:

http://hhg.to/pickle-fix.diff

This problem was causing all pickle-related unit test to fail with
a message like:

"cannot execute invalid frame [..]: frame had a C
state that can't be restored."

(or see http://hhg.to/pickle-fix.txt for example output).

The problem was caused by a PyArg_ParseTuple int/long size
misalignment in cframe_setstate (core/cframeobject.c).

-- Hallgrimur

_______________________________________________
Stackless mailing list
Stackless at stackless.com
http://www.stackless.com/mailman/listinfo/stackless