[Stackless] Patch for pickle problem on 64bit platforms

[Kristján Valur Jónsson]

Sure, I have no issues about using 'long' in these cases, just be aware that it is only 32 bits on win64.

Hm, come to think of it, PyInt_FromLong() et al all expose this 'long' discrepancy.  So, is a normal python integer 64 bits on linux 64?

I suppose its ok to go with long then, we just have to be careful to update all those format strings.  I will make an update soon.

K

> -----Original Message-----
> From: Christian Tismer [mailto:tismer at stackless.com]
> Sent: 19. október 2007 23:02
> To: Kristján Valur Jónsson
> Cc: Hallgrimur H. Gunnarsson; stackless at stackless.com
> Subject: Re: [Stackless] Patch for pickle problem on 64bit platforms
>
> Kristján Valur Jónsson wrote:
> > and again, in run_watchdog().  Here, it ultimately ends up as an int in
> ts->st.interval.
> > Again, confusion.  should we change ts->st.interval into long, or change
> the run_watchdog api to int?
> >
> > grep for "long" in the code.  It is not used very often.  The parts in
> stackless are what you should watch for.
> > Any word on this from our wise guru?
>
> Whoever should be that? :-)
>
> I'd say go for long. But I don't have any reasons than
> a good feeling in the stomach. Long seems to be quite
> close to what we want on 64 bit, no?
>
> Another criterion is to reduce the number of #ifdefs.
> I think this works. So yes, please use the most
> obvious types that seem to be.
>
> cheers -- chris
> --
> Christian Tismer             :^)   <mailto:tismer at stackless.com>
> tismerysoft GmbH             :     Have a break! Take a ride on Python's
> Johannes-Niemeyer-Weg 9A     :    *Starship* http://starship.python.net/
> 14109 Berlin                 :     PGP key -> http://wwwkeys.pgp.net/
> work +49 30 802 86 56  mobile +49 173 24 18 776  fax +49 30 80 90 57 05
> PGP 0x57F3BF04       9064 F4E1 D754 C2FF 1619  305B C09C 5A3B 57F3 BF04
>        whom do you want to sponsor today?   http://www.stackless.com/